fix(tracing): Use integer for content length #8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
mydea and
lforst
and removed request for
a team
AbhiPrasad
commented
May 17, 2023
| @@ -36,7 +36,7 @@ describe('envelope', () => { | |||
| expect(headers).toEqual({ event_id: 'aa3ff046696b4bc6b609ce6d28fde9e2', sent_at: '123' }); | |||
| }); | |||
|
|
|||
| it.only('serializes an envelope with attachments', () => { | |||
| it('serializes an envelope with attachments', () => { | |||
Lms24
approved these changes
May 17, 2023
AbhiPrasad
commented
May 17, 2023
| span.setData('http.response_content_length', contentLength); | ||
|
|
||
| const contentLengthNum = parseInt(contentLength); | ||
| if (contentLengthNum > 0) { |
There was a problem hiding this comment.
this check takes care of NaN also
AbhiPrasad
commented
May 17, 2023
| const postRequestFetchHandlerData = { | ||
| ...fetchHandlerData, | ||
| endTimestamp, | ||
| response: { status: 404, headers: { get: () => 123 } }, |
There was a problem hiding this comment.
shimming out the headers obj since not available in test
There was a problem hiding this comment.
Yeah its painful but I also had to do this somewhere 😅
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.