feat(nextjs): Add automatic monitors for Vercel Cron Jobs #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
May 10, 2023
| logger.info( | ||
| `${chalk.cyan( | ||
| 'info', | ||
| )} - Creating Sentry cron monitors for your Vercel Cron Jobs. You can disable this feature by setting the ${chalk.bold.cyan( |
There was a problem hiding this comment.
m: Should we only log this out if the crons field is defined? Otherwise I can see how this might get confusing
| @@ -42,7 +49,6 @@ export function wrapApiHandlerWithSentryVercelCrons<F extends (...args: any[]) = | |||
| status: 'in_progress', | |||
| }, | |||
| { | |||
| checkinMargin: 2, // two minutes - in case Vercel has a blip | |||
There was a problem hiding this comment.
Had a discussion with the crons team. The missed checkins were a bug in the product when the margin is set to 0.
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
AbhiPrasad
reviewed
May 10, 2023
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.