ref(sveltekit): Improve auto-instrumentation applicability check #8083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
May 9, 2023
| 'function declaration with different string literal name', | ||
| `import { foo } from 'somewhere'; | ||
| async function somethingElse(){}; | ||
| export { somethingElse as "load", foo }`, |
There was a problem hiding this comment.
TIL string literals are legal here
AbhiPrasad
reviewed
May 9, 2023
size-limit report 📦
|
Lms24
force-pushed
the
lms/sveltekit-improve-canWrapLoad
branch
from
e955226
to
4eae534
Compare
|
|
Lms24
force-pushed
the
lms/sveltekit-improve-canWrapLoad
branch
from
4eae534
to
df5667a
Compare
lforst
approved these changes
May 24, 2023
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
canWrapLoadcheck for ourloadauto-instrumentation. Previously, we used a few regexes to strip comments and match certain syntax for auto-wrapping. This proved to be quite brittle and we had to fix some cases (#8049). I just found another case that wasn't handled correctly before so I decided to switch to parsing the module and walking the AST. For this application, IMO AST walking is safer than some brittle regex check, so I vote we go with this approach.I chose MagicAST despite the fact that we only inspect the AST and don't modify it because:
recastand babel under the hood which I would have chosen as an alternative anywayThis check should now cover all possible
exportstatement types that are permitted by SvelteKit. We don't need to handle the rest of the possibilites forexportsyntax because their not applicable in SvelteKit.