ref(serverless): Remove relay extension from AWS layer #8080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
sl0thentr0py
force-pushed
the
neel/remove-aws-relay
branch
3 times, most recently
from
c022489
to
3d02e93
Compare
4 tasks
Lms24
reviewed
May 15, 2023
| @@ -46,6 +46,12 @@ async function buildLambdaLayer(): Promise<void> { | |||
| '../build/npm/cjs/awslambda-auto.js', | |||
| 'build/aws/dist-serverless/nodejs/node_modules/@sentry/serverless/dist/awslambda-auto.js', | |||
| ); | |||
|
|
|||
| const version = run("cat package.json | jq --raw-output '.version'", { stdio: 'pipe' }).trim(); | |||
There was a problem hiding this comment.
h: the jq command errors for me locally because I don't have jq installed on my machine. Can we make sure that this doesn't become a requirement for a successful local build? I think we can either import/require the or read and JSON.parse the package.json instead to get the version.
There was a problem hiding this comment.
Another idea: I just saw that read-pkg is still registered as a dev dependency but we don't seem to use it anywhere. So we could use it to read the package.json here, too. (Or alternatively, let's get rid of it)
There was a problem hiding this comment.
- removed
read-pkg - imported
versionfrompackage.json(needed"resolveJsonModule": trueintsconfig.json)
sl0thentr0py
force-pushed
the
neel/remove-aws-relay
branch
3 times, most recently
from
55ae2f5
to
234a678
Compare
we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out. * revert port override in DSN * remove gh action that bundles relay * zip in place as part of `buildLambdaLayer` part of getsentry/team-webplatform-meta#58
sl0thentr0py
force-pushed
the
neel/remove-aws-relay
branch
from
234a678
to
85a6e60
Compare
Lms24
approved these changes
May 16, 2023
Lms24
changed the title
|
yep, tested manually, will test whole prod flow once released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're reverting back to the older setup since the whole 'relay as AWS extension' experiment didn't really work out.
buildLambdaLayerpart of getsentry/team-webplatform-meta#58
see python PR - getsentry/sentry-python#2068