-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): Unwrap req
and res
if necessary when instrumenting server
#4467
Conversation
size-limit report
|
Hi @lobsterkatie, Is there anything I can help with this PR? |
hi there, when should we expect this land? |
Hey folks, we'll be cutting a patch release right after this gets merged in! Release should be out by end of day today! |
For those watching this PR - getsentry/publish#775 will track the state of the release. When that issue is closed, the release should be out under Edit: Released with https://www.npmjs.com/package/@sentry/nextjs/v/6.17.3 |
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
Recent update of Nextjs broke integration with Sentry and requires update for Sentry package. vercel/next.js#33726 Issue was fixed here: getsentry/sentry-javascript#4467
h/t to @YukiKitagata for finding the relevant change to Next.js and providing an initial implementation of this fix.
In vercel/next.js#32999 (released as part of 12.0.9), Next.js made an internal change, so that it now wraps the raw
http.IncomingMessage
andhttp.ServerResponse
objects which get passed to the main server request handler inNodeNextRequest
andNodeNextResponse
objects, respectively. We therefore need to unwrap them before we can use them.This does that unwrapping (if necessary; older versions of nextjs still don't need it) and fixes the relevant types.
Fixes #4463
Fixes vercel/next.js#33726