Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Revamp express route info extraction #3084

Merged
merged 1 commit into from
Dec 1, 2020
Merged

ref: Revamp express route info extraction #3084

merged 1 commit into from
Dec 1, 2020
+57 −71

Conversation

kamilogorek
Copy link
Contributor

Fixes #3004

@kamilogorek kamilogorek requested a review from a team November 30, 2020 14:54
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.71 KB (-0.01% 🔽)
@sentry/browser - Webpack 20.59 KB (0%)
@sentry/react - Webpack 20.59 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.86 KB (-0.01% 🔽)

lobsterkatie
lobsterkatie reviewed Nov 30, 2020
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Are there tests which cover this already? If not, could we add some?

@kamilogorek
Copy link
Contributor Author

There are tests inside handlers.test.ts that cover most of the possible real-world scenarios.

@kamilogorek kamilogorek merged commit c15967e into master Dec 1, 2020
@kamilogorek kamilogorek deleted the express-path branch December 1, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

event.transaction reports wrong URL when Express is used with a Router
2 participants
@kamilogorek @lobsterkatie