Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracekit): Handle expo file dir stack frames #3070

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Nov 24, 2020

There was an issue with expo bundles where stack frames were missing, with only [native code] frames showing: getsentry/sentry-react-native#1116.

Upon further investigation, I found that stack frames weren't being retained in tracekit as expo bundles have file-directory filenames, for example:

onPress@/data/user/0/com.sentrytest/files/.expo-internal/bundle-613EDD44F3305B9D75D4679663900F2BCDDDC326F247CA3202A3A4219FD412D3:595:658

this PR added a case to the gecko regex to match filenames like above with \/[\w\-. /=]+, and adds tests with a sample expo exception.

Example issues:

Original with missing stack trace frames:
https://sentry.io/organizations/sentry-sdks/issues/2047835101/

With this PR applied:
https://sentry.io/organizations/sentry-sdks/issues/2047835101/

With a fix to sentry-expo:
https://sentry.io/organizations/sentry-sdks/issues/2052035152/

With both fixes and source maps:
https://sentry.io/organizations/sentry-sdks/issues/2052145181/

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.73 KB (+0.08% 🔺)
@sentry/browser - Webpack 20.6 KB (+0.07% 🔺)
@sentry/react - Webpack 20.6 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.88 KB (+0.06% 🔺)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@kamilogorek kamilogorek merged commit 668f44f into master Dec 1, 2020
@kamilogorek kamilogorek deleted the jenn/fix-expo-stack branch December 1, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants