fix(tracekit): Handle expo file dir stack frames #3070
Merged
+55
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with expo bundles where stack frames were missing, with only
[native code]
frames showing: getsentry/sentry-react-native#1116.Upon further investigation, I found that stack frames weren't being retained in
tracekit
as expo bundles have file-directory filenames, for example:this PR added a case to the
gecko
regex to match filenames like above with\/[\w\-. /=]+
, and adds tests with a sample expo exception.Example issues:
Original with missing stack trace frames:
https://sentry.io/organizations/sentry-sdks/issues/2047835101/
With this PR applied:
https://sentry.io/organizations/sentry-sdks/issues/2047835101/
With a fix to
sentry-expo
:https://sentry.io/organizations/sentry-sdks/issues/2052035152/
With both fixes and source maps:
https://sentry.io/organizations/sentry-sdks/issues/2052145181/