fix: Make sure that getSession exists before calling it #3017
Conversation
size-limit report
|
|
👋 we upgraded to Wondering if this didn't quite fix (seems like it should have 🤷)
Or maybe this fix hasn't been pushed everywhere yet? It doesn't seem to be in https://browser.sentry-cdn.com/5.27.2/bundle.min.js |
| @@ -522,7 +522,7 @@ export abstract class BaseClient<B extends Backend, O extends Options> implement | |||
| throw new SentryError('`beforeSend` returned `null`, will not send event.'); | |||
| } | |||
|
|
|||
| const session = scope && scope.getSession(); | |||
| const session = scope && scope.getSession && scope.getSession(); | |||
There was a problem hiding this comment.
What about simply using ?.? (same comment for the second file in this PR)
const session = scope && scope.getSession?.();Is its compatibility enough for you?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#Browser_compatibility
There was a problem hiding this comment.
Yes, we could do that, as we're compiling it down to ES5 anyway. Good catch.
There was a problem hiding this comment.
For that matter, couldn't we just do
const session = scope?.getSession?.();
?
This can happen when malformed node_modules are using older version of
hub, butcorewants to call that method. Or when there are 2 versions of Sentry living next to each other for some unknown reason. Fix is straightforward enough that I'm fine to include it, and we already got 2 customers reporting this issue.