fix(browser): Call removeEventListener twice only when necessary #3016

kamilogorek · 2020-10-29T13:32:55Z

This takes time to finish https://github.com/mshanfard/sentry-debug (repro case) test suite from 54s to 14s. Without Sentry it's ~9-10s.

github-actions · 2020-10-29T13:44:25Z

size-limit report

Path	Size
@sentry/browser - CDN Bundle (gzipped)	19.65 KB (+0.09% 🔺)
@sentry/browser - Webpack	20.51 KB (+0.16% 🔺)
@sentry/react - Webpack	20.51 KB (+0.16% 🔺)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)	26.64 KB (+0.06% 🔺)

lobsterkatie

LGTM

fix: Dont call removeEventListener for functions that were not wrapped

1330ee5

kamilogorek requested review from HazAT and lobsterkatie October 29, 2020 13:32

more explanatory variable names

cdc402e

lobsterkatie approved these changes Oct 30, 2020

View reviewed changes

lobsterkatie changed the title ~~fix: Dont call removeEventListener for functions that were not wrapped~~ fix(browser): Call removeEventListener twice only when necessary Oct 30, 2020

lobsterkatie merged commit 8489072 into master Oct 30, 2020

lobsterkatie deleted the fix-dont-remove-unnecessary-listeners branch October 30, 2020 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(browser): Call removeEventListener twice only when necessary #3016

fix(browser): Call removeEventListener twice only when necessary #3016

kamilogorek commented Oct 29, 2020

github-actions bot commented Oct 29, 2020 •

edited

Loading

lobsterkatie left a comment

fix(browser): Call removeEventListener twice only when necessary #3016

fix(browser): Call removeEventListener twice only when necessary #3016

Conversation

kamilogorek commented Oct 29, 2020

github-actions bot commented Oct 29, 2020 • edited Loading

size-limit report

lobsterkatie left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 29, 2020 •

edited

Loading