Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Delete sentry/apm package #2990

Merged
merged 2 commits into from
Oct 23, 2020
Merged

ref: Delete sentry/apm package #2990

merged 2 commits into from
Oct 23, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Oct 22, 2020

No description provided.

@HazAT HazAT requested a review from kamilogorek as a code owner October 22, 2020 07:56
@HazAT HazAT self-assigned this Oct 22, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2020

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.62 KB (+0.01% 🔺)
@sentry/browser - Webpack 20.46 KB (0%)
@sentry/react - Webpack 20.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.61 KB (+0.01% 🔺)

@kamilogorek
Copy link
Contributor

Please update APM references in:

package.json
packages/react/src/profiler.tsx
packages/react/README.md
packages/integrations/src/vue.ts
packages/utils/src/instrument.ts
packages/tracing/src/index.ts

Not sure about packages/tracing/README.md

@HazAT
Copy link
Member Author

HazAT commented Oct 22, 2020

I would leave the deprecated getter for apm in place in Vue/React until we do a major bump.

HazAT added 2 commits October 23, 2020 12:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@HazAT HazAT force-pushed the ref/remove-sentry-apm branch from 8693e3f to 9995fad Compare October 23, 2020 10:35
@HazAT HazAT merged commit a0b636b into master Oct 23, 2020
@HazAT HazAT deleted the ref/remove-sentry-apm branch October 23, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants