Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): Capture time spent redirecting before loading the current page #2986

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

dashed
Copy link
Member

@dashed dashed commented Oct 20, 2020

Ref:

If there is no redirect, or if one of the redirect is not of the same origin, then values for either redirectStart or redirectEnd is 0, and thus, no span is created.

This can reveal any server or CDN configuration issues that can add any unnecessary time to the page load time.

@dashed dashed requested review from a team October 20, 2020 03:52
@dashed dashed requested a review from kamilogorek as a code owner October 20, 2020 03:52
@dashed dashed self-assigned this Oct 20, 2020
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 19.59 KB (-0.01% 🔽)
@sentry/browser - Webpack 20.42 KB (0%)
@sentry/react - Webpack 20.42 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 26.55 KB (+0.04% 🔺)

@kamilogorek kamilogorek merged commit 0a305f6 into master Oct 20, 2020
@kamilogorek kamilogorek deleted the redirect-span branch October 20, 2020 10:28
@kamilogorek
Copy link
Contributor

I allowed to merged it myself, as it's a simple one-liner, and I'll include in the next beta release Today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants