feat(rum): Add more web vitals: CLS and TTFB #2964
Merged
+212
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
kamilogorek
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation from #2909.
Add the rest of the available web vitals, specifically:
measurements.cls) - https://web.dev/cls/measurements.ttfb) - https://web.dev/time-to-first-byte/measurements.ttfb.requestTime, which measures the time spent making the request and receiving the first byte of the response.Sourced from: https://github.com/GoogleChrome/web-vitals specifically 56c736b7c4e80f295bc8a98017671c95231fa225. This is already on the vendored web-vitals README file.