-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @sentry/vue #2953
feat: @sentry/vue #2953
Conversation
566b863
to
b851ae7
Compare
size-limit report
|
476b96d
to
8bce74a
Compare
6e8bd06
to
feb24d9
Compare
export function init( | ||
options: Partial<Omit<VueOptions, 'tracingOptions'> & { tracingOptions: Partial<TracingOptions> }> = {}, | ||
): void { | ||
if (options.defaultIntegrations === undefined) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options.defaultIntegrations === true
should also do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can also be an array, we have this logic everywhere so I rather not change it just here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh, then we have a bug in 4 places :(
Sentry.init({
defaultIntegrations: true
})
should work, but it won't now. Can we fix it in this PR plz?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of the option is defined as defaultIntegrations?: false | Integration[];
So either it has to be omitted, or false or array. It can't be set to true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
Co-authored-by: Kamil Ogórek <kamil.ogorek@gmail.com>
@sentry/vue SDK no support for Vue3 yet.
getsentry/sentry-docs#2689