-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(tracing): Clean up various things before fixing sampling #2944
Merged
+348
−228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
77425d6
to
58f7f3f
Compare
It'll fix #2943 as well |
kamilogorek
reviewed
Sep 30, 2020
kamilogorek
reviewed
Sep 30, 2020
kamilogorek
suggested changes
Sep 30, 2020
kamilogorek
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2921, to try to make it less of an unwieldy mess. Random refactoring of stuff - mostly tests - not directly related to those changes, but which came as a consequence of working on that.
I believe the only minorly substantive changes are:
beforeNavigate
which did nothing (in order that the option be able to be required), which I removed in favor of letting the option be optional and only runningbeforeNavigate
if it's defined.Response
type since it's a dom type and not everyone compiles with those.There's a bunch here, but I did my best to keep my commits clean* so it would be possible to look at each one individually and make sure I'm not doing anything nuts or breaking.
*only about one thing, named appropriately, with passing tests at each stage