feat: Give access to XHR requests body in breadcrumb hint #2904
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
rhcarvalho
reviewed
Sep 15, 2020
| @@ -220,6 +223,9 @@ function instrumentXHR(): void { | |||
| return; | |||
| } | |||
|
|
|||
| // Poor man implementation of ES6 `Map` by tracking and keeping in sync key and value separately. | |||
There was a problem hiding this comment.
Could concurrent requests get this "map" out of sync? I think not, no pre-emption.
There was a problem hiding this comment.
Nah, it's not Go 😅
rhcarvalho
approved these changes
Sep 15, 2020
|
Would it be possible to make this configurable? Including XRH request bodies at my org would be a no-go since they often will contain PHI that we can't log. We'd basically have to turn off breadcrumbs entirely. |
|
great -- thanks @kamilogorek ! |
lobsterkatie
added a commit
that referenced
this pull request
Jan 18, 2022
This simplifies the implementation of XHR request body harvesting for breadcrumbs, introduced in #2904. Instead of caching the data and grabbing it at a later point, this grabs it as soon as it's available, in the xhr `send` method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2166