Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow for empty DSN/disabling with AngularJS integration #2842

Merged
merged 1 commit into from
Aug 24, 2020
Merged

fix: Allow for empty DSN/disabling with AngularJS integration #2842

merged 1 commit into from
Aug 24, 2020
+16 −3

Conversation

kamilogorek
Copy link
Contributor

@kamilogorek kamilogorek commented Aug 24, 2020 •
edited
Loading

This will always register at least an empty module with a ngSentry name, which prevents the "undefined module" error when setupOnce is never called (due to empty DSN or disable:true).

Fixes #2369

@kamilogorek
fix: Allow for empty DSN/disabling with AngularJS integration

Verified

This commit was signed with the committer’s verified signature.
fredbi fredbi
GPG key ID: DC85F39C3ECFBDBF
Verified
Learn about vigilant mode
916780a
@kamilogorek kamilogorek requested a review from a team August 24, 2020 13:39
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.67 KB (0%)
@sentry/browser - Webpack 18.46 KB (0%)
@sentry/react - Webpack 18.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.77 KB (0%)

AbhiPrasad
AbhiPrasad approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kamilogorek kamilogorek merged commit 0df3981 into master Aug 24, 2020
@kamilogorek kamilogorek deleted the angular-empty-dsn branch August 24, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty DSN with AngularJS integration
2 participants
@kamilogorek @AbhiPrasad