Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): Track span status for fetch requests #2835

Merged
merged 3 commits into from
Aug 21, 2020
Merged

feat(tracing): Track span status for fetch requests #2835

merged 3 commits into from
Aug 21, 2020
+35 −1

Conversation

AbhiPrasad
Copy link
Member

We were not tracking span status for fetch requests. This PR changes that.

@AbhiPrasad AbhiPrasad requested a review from a team August 21, 2020 15:03
@AbhiPrasad AbhiPrasad changed the title feat(tracing): Track span status for requests feat(tracing): Track span status for fetch requests Aug 21, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2020 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.67 KB (0%)
@sentry/browser - Webpack 18.46 KB (0%)
@sentry/react - Webpack 18.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.69 KB (-0.32% 🔽)

HazAT
HazAT approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upsi

@AbhiPrasad AbhiPrasad merged commit c7c365a into master Aug 21, 2020
@AbhiPrasad AbhiPrasad deleted the abhi/span-status branch August 21, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT

@kamilogorek kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @HazAT