ref(tracing): Make sure error status is set on transactions #2818
+25
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi/global-errors
branch
from
dee8a78 to
adc794d
Compare
AbhiPrasad
commented
Aug 13, 2020
| @@ -171,9 +170,6 @@ export class BrowserTracing implements Integration { | |||
| startTransactionOnLocationChange, | |||
| ); | |||
|
|
|||
| // TODO: Should this be default behaviour? | |||
| registerErrorInstrumentation(); | |||
There was a problem hiding this comment.
The answer is yes, yes it should be 😄
size-limit report
|
kamilogorek
approved these changes
Aug 14, 2020
AbhiPrasad
force-pushed
the
abhi/global-errors
branch
from
adc794d to
3839bb4
Compare
rhcarvalho
approved these changes
Aug 19, 2020
HazAT
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that for all transactions on the scope in the JS SDK, if an error occurs that the span status is changed to error. This previously only existed for transactions inside the tracing integration.