feat(tracing): Change resource span op name and add data #2816
+158
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
AbhiPrasad
force-pushed
the
abhi/performance-entry
branch
3 times, most recently
from
b8a4d95 to
9881251
Compare
k-fish
reviewed
Aug 13, 2020
k-fish
requested changes
Aug 13, 2020
| if (entry.decodedBodySize) { | ||
| data.decodedBodySize = entry.decodedBodySize; | ||
| } | ||
|
|
There was a problem hiding this comment.
We also need a timing (such as responseStart) to exclude cross-origin resources that aren't setup to allow timing.
There was a problem hiding this comment.
We also could include some sort of comparison (eg. entry.name.startsWith(window.location.origin)) to determine whether the resource is cross-origin explicitly.
There was a problem hiding this comment.
I will leave this for the future, merging this in for now.
Opening a ticket.
kamilogorek
reviewed
Aug 14, 2020
kamilogorek
reviewed
Aug 14, 2020
AbhiPrasad
force-pushed
the
abhi/performance-entry
branch
from
9881251 to
a68731c
Compare
dashed
approved these changes
Aug 14, 2020
AbhiPrasad
force-pushed
the
abhi/performance-entry
branch
from
a68731c to
8bb9c42
Compare
AbhiPrasad
force-pushed
the
abhi/performance-entry
branch
from
8bb9c42 to
49a5d6e
Compare
rhcarvalho
reviewed
Aug 19, 2020
| @@ -226,14 +234,26 @@ function addResourceSpans( | |||
| return undefined; | |||
| } | |||
|
|
|||
| const data: Record<string, any> = {}; | |||
| if ('transferSize' in entry) { | |||
| data.transferSize = entry.transferSize; | |||
There was a problem hiding this comment.
Given that arbitrary data fields are not special-cased in the UI to make them read nice, would it be desirable here to use a "pretty" format like data["Transfer Size"]? cc @dashed
Specifically:
HazAT
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
transferSize,encodedBodySize, anddecodedBodySizemetrics to resource spans and adjust resource op name to account forinitiatorType(ex.resource.css,resource.img)This ones for 🇨🇦