Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export addExtensionMethods for SDKs to use #2805

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

AbhiPrasad
Copy link
Member

In case a user for some reason cannot access the side effect, let's let them import and call it themselves.

This can also be used by SDKs like react-native/electron etc. to call the extensions themselves.

@AbhiPrasad AbhiPrasad requested a review from HazAT August 10, 2020 19:45
@github-actions
Copy link
Contributor

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.65 KB (0%)
@sentry/browser - Webpack 18.41 KB (0%)
@sentry/react - Webpack 18.41 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.66 KB (+0.11% 🔺)

@getsentry-bot
Copy link
Contributor

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.25 kB) (ES6: 16.3525 kB)

📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 99969b9

@HazAT HazAT merged commit b2e191f into master Aug 11, 2020
@HazAT HazAT deleted the abhi/export-extension-methods branch August 11, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants