Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apm|tracing): Remove express typing #2803

Merged
merged 1 commit into from
Aug 10, 2020
Merged

feat(apm|tracing): Remove express typing #2803

merged 1 commit into from
Aug 10, 2020
+32 −4

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Aug 10, 2020 •
edited
Loading

Manually set types so that users don't complain about importing typscript types for express.

@AbhiPrasad AbhiPrasad force-pushed the abhi/remove-express-typing branch from ba76193 to c3a5205 Compare August 10, 2020 14:34
HazAT
HazAT approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2020 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.65 KB (0%)
@sentry/browser - Webpack 18.41 KB (0%)
@sentry/react - Webpack 18.41 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.64 KB (0%)

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Aug 10, 2020 •
edited
Loading

Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖

@sentry/browser bundle gzip'ed minified size: (ES5: 17.251 kB) (ES6: 16.3525 kB)
📖 ✅ TSLint passed

Generated by 🚫 dangerJS against 6e26a15

@AbhiPrasad AbhiPrasad force-pushed the abhi/remove-express-typing branch from c3a5205 to 6e26a15 Compare August 10, 2020 14:54
@AbhiPrasad AbhiPrasad merged commit 1b28c23 into master Aug 10, 2020
@AbhiPrasad AbhiPrasad deleted the abhi/remove-express-typing branch August 10, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HazAT HazAT

@kamilogorek kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AbhiPrasad @getsentry-bot @HazAT