feat: Add basic router instrumentation for @sentry/ember #2784
+587
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add routing instrumentation for Ember transitions to @sentry/ember. The import will be dynamically loading depending on configuration settings with to not increase bundle size.
k-fish
force-pushed
the
feat/sentry-ember-perf
branch
from
279ebcd to
d80ee32
Compare
size-limit report
|
kamilogorek
reviewed
Jul 30, 2020
kamilogorek
reviewed
Aug 27, 2020
packages/ember/addon/instance-initializers/sentry-performance.ts
Outdated
Show resolved
Hide resolved
kamilogorek
previously approved these changes
Aug 27, 2020
…rformance integration gets bound as otherwise default integrations won't be included
AbhiPrasad
reviewed
Aug 28, 2020
packages/ember/addon/instance-initializers/sentry-performance.ts
Outdated
Show resolved
Hide resolved
…operly. Split off router instrumentation to allow for use in testing
k-fish
changed the title
rhcarvalho
previously requested changes
Sep 4, 2020
There was a problem hiding this comment.
@k-fish thanks for contributing this, it's exciting to have first-class support for route changes in yet another popular framework ❤️
Looked at previous reviews, at least #2784 (comment) needs to be addressed before this is mergeable.
I'm marking this with a "request changes" and added an item to the TODO in the PR description for visibility of where we stand.
|
@rhcarvalho that comment was actually resolved already, I spread the existing integrations now on the line below, and add this Ember instrumentation as an additional integration. |
kamilogorek
reviewed
Sep 7, 2020
|
JS code-wise looks good, I'm not able to tell much about ember-specific code though. Left one question. Feel free to merge once addressed. |
kamilogorek
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This will add routing instrumentation for Ember transitions to @sentry/ember.
beforeModelmodelandafterModelwill come in a later PR.Looking for feedback specifically on using the route names in lieu of urls like React. There isn't as clean of a way to match urls like we do with react-router, so I'm currently using format for Ember's registry
router:<route-name>.Screenshot
Added tracing route to the dummy so navigating to the new route can be tested.
Todo