feat: No longer debounce IdleTransaction #2618
Merged
+27
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't verify the functionality myself, but looks good codewise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we debouce a
setTimeoutevery time an activity is popped.This resulted in sometimes the
IdleTransactionnever finishing because there was constantly an activity blocking flushing the Transaction.This PR changes the behavior that once all activities are done the
setTimeoutis triggered and will fire regardless.In addition we discard any Spans that might have been recorded after the Transaction was marked for flushing. This fixes a bug where we had very long Transactions recorded because they weren't flushed + we recorded Spans at the very end -> resulting in absurdly long Transactions.