Skip to content

feat(core): Rename hasTracingEnabled to hasSpansEnabled #15309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 5, 2025

This PR renames the hasTracingEnabled utility function to hasSpansEnabled. The original name is causing confusion and doesn't represent what the function actually does: determining if the SDK is configured to record spans. This function does not check if trace propagation without span recording (or "Tracing without Performance") is enabled (which it basically always is).

Since this function is exported from @sentry/core, hasTracingEnabled was deprecated and will be removed in v10.

Lms24 added 2 commits February 5, 2025 14:37
@Lms24 Lms24 self-assigned this Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.9 KB +0.03% +5 B 🔺
@sentry/browser - with treeshaking flags 22.77 KB +0.04% +8 B 🔺
@sentry/browser (incl. Tracing) 35.77 KB - -
@sentry/browser (incl. Tracing, Replay) 72.58 KB -0.01% -1 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.13 KB +0.01% +3 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 76.82 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.56 KB +0.01% +2 B 🔺
@sentry/browser (incl. Feedback) 39.84 KB +0.02% +7 B 🔺
@sentry/browser (incl. sendFeedback) 27.53 KB +0.02% +4 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.31 KB +0.03% +7 B 🔺
@sentry/react 24.73 KB +0.02% +5 B 🔺
@sentry/react (incl. Tracing) 37.67 KB +0.01% +1 B 🔺
@sentry/vue 27.09 KB +0.01% +1 B 🔺
@sentry/vue (incl. Tracing) 37.47 KB -0.01% -1 B 🔽
@sentry/svelte 23.03 KB +0.03% +5 B 🔺
CDN Bundle 24.2 KB +0.01% +1 B 🔺
CDN Bundle (incl. Tracing) 35.92 KB +0.01% +2 B 🔺
CDN Bundle (incl. Tracing, Replay) 70.56 KB +0.01% +2 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 75.7 KB +0.01% +3 B 🔺
CDN Bundle - uncompressed 70.76 KB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 106.64 KB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.49 KB -0.01% -4 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.06 KB -0.01% -4 B 🔽
@sentry/nextjs (client) 38.63 KB - -
@sentry/sveltekit (client) 36.28 KB -0.01% -2 B 🔽
@sentry/node 156.51 KB -0.01% -4 B 🔽
@sentry/node - without tracing 97.52 KB - -
@sentry/aws-serverless 107 KB -0.01% -4 B 🔽

View base workflow run

Copy link

codecov bot commented Feb 5, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
698 1 697 301
View the full list of 1 ❄️ flaky tests
sdk.test.ts SDK-internal behaviorInjects fetch proxy script for SvelteKit<2.16.0

Flake rate in main: 30.00% (Passed 14 times, Failed 6 times)

Stack Traces | 0.126s run time
sdk.test.ts:4:3 Injects fetch proxy script for SvelteKit<2.16.0

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Lms24 Lms24 merged commit 447911a into develop Feb 5, 2025
143 of 145 checks passed
@Lms24 Lms24 deleted the lms/feat-core-rename-hasTracingEnabled branch February 5, 2025 15:35
@Lms24
Copy link
Member Author

Lms24 commented Feb 5, 2025

Side-note: I went through every usage call we make to this function while renaming and 1. the conditions now read way more clearer and 2. I didn't come acrross suspicios usages where this check doesn't seem applicable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants