Skip to content

ref(core)!: Move shutdownTimeout option type from core to node #15217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 29, 2025

We used to have shutdownTimeout in the core client options, but this option only applies in node, so we can move it there. Also fixing a small unnecessary check I noticed along the way.

This is technically breaking, but should not affect anybody as this option is not used (and documented) anywhere outside of node.

@mydea mydea requested review from Lms24 and andreiborza January 29, 2025 12:29
@mydea mydea self-assigned this Jan 29, 2025
Copy link
Contributor

github-actions bot commented Jan 29, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.05 KB -0.03% -5 B 🔽
@sentry/browser - with treeshaking flags 22.94 KB -0.03% -6 B 🔽
@sentry/browser (incl. Tracing) 35.78 KB -0.02% -6 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.57 KB -0.01% -5 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.12 KB -0.02% -8 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.82 KB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 89.31 KB -0.01% -9 B 🔽
@sentry/browser (incl. Feedback) 39.73 KB -0.03% -10 B 🔽
@sentry/browser (incl. sendFeedback) 27.68 KB -0.03% -7 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.46 KB -0.03% -8 B 🔽
@sentry/react 25.72 KB -0.04% -8 B 🔽
@sentry/react (incl. Tracing) 38.55 KB -0.03% -9 B 🔽
@sentry/vue 27.15 KB -0.03% -7 B 🔽
@sentry/vue (incl. Tracing) 37.51 KB -0.03% -9 B 🔽
@sentry/svelte 23.18 KB -0.02% -4 B 🔽
CDN Bundle 24.27 KB -0.03% -7 B 🔽
CDN Bundle (incl. Tracing) 35.91 KB -0.03% -8 B 🔽
CDN Bundle (incl. Tracing, Replay) 70.53 KB -0.02% -8 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 75.67 KB -0.02% -9 B 🔽
CDN Bundle - uncompressed 70.92 KB -0.04% -28 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 106.55 KB -0.03% -28 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.41 KB -0.02% -28 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 229.97 KB -0.02% -28 B 🔽
@sentry/nextjs (client) 38.65 KB -0.03% -9 B 🔽
@sentry/sveltekit (client) 36.29 KB -0.03% -8 B 🔽
@sentry/node 156.39 KB - -
@sentry/node - without tracing 97.48 KB - -
@sentry/aws-serverless 106.94 KB -0.01% -1 B 🔽

View base workflow run

We used to have `shutdownTimeout` in the core client options, but this option only applies in node, so we can move it there. Also fixing a small unnecessary check I noticed along the way.
@mydea mydea force-pushed the fn/type-adjustments branch from ce91ea3 to 3709fff Compare January 29, 2025 13:51
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Technically this is breaking, so let's add a ! in the PR title/commit msg

@mydea mydea changed the title ref: Small type adjustment ref!: Small type adjustment Jan 29, 2025
@mydea mydea changed the title ref!: Small type adjustment ref!: Move shutdownTimeout option type from core to node Jan 29, 2025
@mydea mydea changed the title ref!: Move shutdownTimeout option type from core to node ref(core)!: Move shutdownTimeout option type from core to node Jan 29, 2025
@mydea mydea merged commit 6e03449 into develop Jan 29, 2025
143 checks passed
@mydea mydea deleted the fn/type-adjustments branch January 29, 2025 14:17
antonis added a commit to getsentry/sentry-react-native that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants