feat(sveltekit): Only inject fetch proxy script for SvelteKit < 2.16.0 #15126
+91
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
from
44f6aea to
ce32c24
Compare
Base automatically changed from
lms/feat-sveltekit-remove-fetch-proxy-nonce
to
develop
January 22, 2025 11:32
Lms24
force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
3 times, most recently
from
46cc1a4 to
a0bc030
Compare
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Lms24
force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
from
383920f to
f52fd16
Compare
Lms24
commented
Jan 28, 2025
dev-packages/e2e-tests/test-applications/sveltekit-2-twp/tests/sdk.test.ts
Outdated
Show resolved
Hide resolved
Lms24
requested review from
a team,
mydea and
s1gr1d
and removed request for
a team
Lms24
force-pushed
the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
from
f52fd16 to
0b53e27
Compare
mydea
reviewed
Jan 31, 2025
| if (options.injectFetchProxyScript == null) { | ||
| try { | ||
| // @ts-expect-error - the dynamic import is fine here | ||
| const { VERSION } = await import('@sveltejs/kit'); |
There was a problem hiding this comment.
l: Does it make sense to cache this somewhere? 🤔
There was a problem hiding this comment.
We do :) options.injectFetchProxyScript will only be set once
Lms24
deleted the
lms/feat-sveltekit-check-version-for-proxy-script-inject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With v9 onwards, we'll only inject the fetch proxy script into SvelteKit versions where we actually need it. This is all kit versions below 2.16.0. I'll update docs in a follow-up PR.
fixes #15007