feat(remix)!: Remove autoInstrumentRemix option
#15074
Merged
+48
−2,503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
@onurtemizkan I am a bit lost as to why the integration tests are failing. Would you mind taking a look? |
|
@lforst - Sure, checking now 👍 |
|
Oh damn, totally missed that. Thank you so much! |
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 25, 2025
This PR adds support for Shopify Hydrogen applications running on MiniOxygen runtime. ### What's updated **Issue with `node:async_hooks`** (#5610 (comment)) - `@sentry/cloudflare` has a new export path called `./request` to import only the request wrapper without involving `async.ts` which imports `node:async_hooks`. That fixes the build problems on the MiniOxygen environment. **Issue with imported empty modules on MiniOxygen** (Related: vitejs/vite#10612) - `@sentry/remix` has a new export path called `./cloudflare` to fix empty methods in the imported modules. The problem there seemed to be the re-exports that are somehow not resolved. So with this, I also updated the file structure of Remix SDK to separate the client/server/cloudflare code with their own per-folder `index` files. **Issue having `loader` and `action` spans** - This is currently [not supported](https://github.com/justindsmith/opentelemetry-instrumentations-js/tree/main/packages/instrumentation-remix#cloudflare-worker-warning) on `cloudflare` environments on the auto-instrumented flow. To support them, I re-introduced the span creation flow we were using before migration. That's a step back from #15074, but by default this logic is disabled. It's enabled by default when `instrumentBuild` is imported from `@sentry/remix/cloudflare`. **The root server spans are not parameterised** That's because we don't have the Remix routes information on `@sentry/cloudflare`'s request wrapper. I have tried updating the root span's name inside `@sentry/remix/cloudflare`'s logic and it works. But I have left it out for now, not to make this PR even more difficult to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14312