Skip to content

feat(nextjs)!: Don't rely on Next.js Build ID for release names #14939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 9, 2025
Merged

feat(nextjs)!: Don't rely on Next.js Build ID for release names #14939

merged 4 commits into from
Jan 9, 2025
+108 −58

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 8, 2025 •
edited
Loading

Resolves #14940

lforst added 2 commits January 8, 2025 13:11
@lforst
feat(nextjs)!: Don't rely on Next.js Build ID for release names

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
Loading
Loading status checks…
ea65bd7
@lforst
Remove note

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
Loading
Loading status checks…
ef8ce7d
@lforst lforst marked this pull request as ready for review January 8, 2025 13:16
@lforst
Update tsts

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
Loading
Loading status checks…
0b9345a
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
84 1 83 8
View the full list of 1 ❄️ flaky tests 
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes

Flake rate in main: 10.71% (Passed 25 times, Failed 3 times)

Stack Traces | 30s run time 
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@lforst lforst requested a review from chargome January 8, 2025 14:35
chargome
chargome approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/migration/v8-to-v9.md Outdated
@@ -388,6 +394,7 @@ The Sentry metrics beta has ended and the metrics API has been removed from the
## `@sentry/nextjs`

- Deprecated `hideSourceMaps`. No replacements. The SDK emits hidden sourcemaps by default.
-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to add anything here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh whoops

@lforst
.

Verified

This commit was signed with the committer’s verified signature.
lforst Luca Forstner
SSH Key Fingerprint: ljpBJ7bYHpwPGV7Y7sJZM+cMS44wfy1fkQqwY/900Nw
Verified
Learn about vigilant mode
Loading
Loading status checks…
64eec73
@lforst lforst merged commit 550288e into develop Jan 9, 2025
153 checks passed
@lforst lforst deleted the lforst-dont-rely-on-buildid branch January 9, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chargome chargome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v9] Don't rely on Next.js Build ID for release names
2 participants
@lforst @chargome