-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta(changelog): Update changelog for 8.43.0 #14639
Merged
Merged
+8,956
−1,344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try-javascript into aliu/launch-darkly
…try-javascript into aliu/launch-darkly
…ag field and methods
Updates readme based on this PR: #14254
…4605) Adds serverless (e.g. Vercel, Netlify) improvements: - Cloining/forking the isolation context when needed - flushing at the end of the h3 event handler and when an error happens - using Vercel's `waitUntil` for waiting on Sentry events to send before shutting down the function
…13868) Depending on this (because of the link in the warning): getsentry/sentry-docs#11486
E2E tests and usage in nuxt in: #14612 --------- Co-authored-by: Sigrid Huemer <32902192+s1gr1d@users.noreply.github.com>
Types for react cache are incompatible so we pin it for now.
Includes the following fixes: - fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222)) - fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
Adds Sentry tracing instrumentation for the [ai](https://www.npmjs.com/package/ai) library. For more information, see the [`ai` documentation](https://sdk.vercel.ai/docs/ai-sdk-core/telemetry). ```javascript const Sentry = require('@sentry/node'); Sentry.init({ integrations: [Sentry.vercelAIIntegration()], }); ``` By default this integration adds tracing support to all `ai` callsites. If you need to disable collecting spans for a specific call, you can do so by setting `experimental_telemetry.isEnabled` to `false` in the first argument of the function call. ```javascript const result = await generateText({ model: openai('gpt-4-turbo'), experimental_telemetry: { isEnabled: false }, }); ``` If you want to collect inputs and outputs for a specific call, you must specifically opt-in to each function call by setting `experimental_telemetry.recordInputs` and `experimental_telemetry.recordOutputs` to `true`. ```javascript const result = await generateText({ model: openai('gpt-4-turbo'), experimental_telemetry: { isEnabled: true, recordInputs: true, recordOutputs: true }, }); ```
Adds support for Astro 5 and an E2E test app for Astro 5 with the new [server islands](https://docs.astro.build/en/guides/server-islands/) feature. For server islands, we emit a new `http.server` transaction for the island-specific additional http requests. Which is generally good IMO, given that server island requests are routed to the automatically generated `/_server-island/[name]` Astro endpoint.
…y default (#14595) We have internal [user reports](https://sentry.slack.com/archives/CTZCE4WBZ/p1733360320054299) about an uncaught promise rejection being thrown by a .NET library called CEFSharp. This lib can embed chromium in a .NET app, which means, a web page can be displayed within a .NET app. Apparently there's some problem that spams this error to some of our users.
Bumps [@sentry/webpack-plugin](https://github.com/getsentry/sentry-javascript-bundler-plugins) from 2.22.6 to 2.22.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/releases"><code>@sentry/webpack-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>2.22.7</h2> <ul> <li>deps: Bump <code>@sentry/cli</code> to <code>2.39.1</code> and require specific version (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/632">#632</a>)</li> <li>feat(telemetry): Record if plugin is run in CI (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/627">#627</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/main/CHANGELOG.md"><code>@sentry/webpack-plugin</code>'s changelog</a>.</em></p> <blockquote> <h2>2.22.7</h2> <ul> <li>deps: Bump <code>@sentry/cli</code> to <code>2.39.1</code> and require specific version (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/632">#632</a>)</li> <li>feat(telemetry): Record if plugin is run in CI (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/627">#627</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/31978d7a3fc278f42b5f1fbbc72d27dd34426f98"><code>31978d7</code></a> release: 2.22.7</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/514055a1dbcf80cf4ca60967b233696e50e0b11d"><code>514055a</code></a> meta: Update changelog for 2.22.7</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/7dfea7bad45c825090819bdca09017649a4a5e38"><code>7dfea7b</code></a> deps: Bump <code>@sentry/cli</code> to <code>2.39.1</code> and require specific version (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/632">#632</a>)</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/040814d43e62f419ce9da4a055fde13bc3216f30"><code>040814d</code></a> feat(telemetry): Record if plugin is run in CI (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/627">#627</a>)</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/f7c468d9b85c95fe15ce66a124bbf83a6b4d3c15"><code>f7c468d</code></a> chore: Log only to stderr (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/624">#624</a>)</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/7f984482c73e4284e8b12a08dfedf23b5a82f0af"><code>7f98448</code></a> Merge branch 'release/2.22.6'</li> <li>See full diff in <a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/compare/2.22.6...2.22.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/rollup-plugin](https://github.com/getsentry/sentry-javascript-bundler-plugins) from 2.22.6 to 2.22.7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/releases"><code>@sentry/rollup-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>2.22.7</h2> <ul> <li>deps: Bump <code>@sentry/cli</code> to <code>2.39.1</code> and require specific version (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/632">#632</a>)</li> <li>feat(telemetry): Record if plugin is run in CI (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/627">#627</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/main/CHANGELOG.md"><code>@sentry/rollup-plugin</code>'s changelog</a>.</em></p> <blockquote> <h2>2.22.7</h2> <ul> <li>deps: Bump <code>@sentry/cli</code> to <code>2.39.1</code> and require specific version (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/632">#632</a>)</li> <li>feat(telemetry): Record if plugin is run in CI (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/627">#627</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/31978d7a3fc278f42b5f1fbbc72d27dd34426f98"><code>31978d7</code></a> release: 2.22.7</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/514055a1dbcf80cf4ca60967b233696e50e0b11d"><code>514055a</code></a> meta: Update changelog for 2.22.7</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/7dfea7bad45c825090819bdca09017649a4a5e38"><code>7dfea7b</code></a> deps: Bump <code>@sentry/cli</code> to <code>2.39.1</code> and require specific version (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/632">#632</a>)</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/040814d43e62f419ce9da4a055fde13bc3216f30"><code>040814d</code></a> feat(telemetry): Record if plugin is run in CI (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/627">#627</a>)</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/f7c468d9b85c95fe15ce66a124bbf83a6b4d3c15"><code>f7c468d</code></a> chore: Log only to stderr (<a href="https://redirect.github.com/getsentry/sentry-javascript-bundler-plugins/issues/624">#624</a>)</li> <li><a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/commit/7f984482c73e4284e8b12a08dfedf23b5a82f0af"><code>7f98448</code></a> Merge branch 'release/2.22.6'</li> <li>See full diff in <a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/compare/2.22.6...2.22.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#14625) Bumps [@opentelemetry/instrumentation](https://github.com/open-telemetry/opentelemetry-js) from 0.55.0 to 0.56.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/open-telemetry/opentelemetry-js/releases"><code>@opentelemetry/instrumentation</code>'s releases</a>.</em></p> <blockquote> <h2>experimental/v0.56.0</h2> <h2>0.56.0</h2> <h3>:boom: Breaking Change</h3> <ul> <li>feat(otlp-exporter-base)!: collapse base classes into one <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5031">#5031</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a> <ul> <li><code>OTLPExporterNodeBase</code> has been removed in favor of a platform-agnostic implementation (<code>OTLPExporterBase</code>)</li> <li><code>OTLPExporterBrowserBase</code> has been removed in favor of a platform-agnostic implementation (<code>OTLPExporterBase</code>)</li> <li><code>ExportServiceError</code> was intended for internal use and has been dropped from exports</li> <li><code>validateAndNormalizeHeaders</code> was intended for internal use and has been dropped from exports</li> <li><code>OTLPExporterBase</code> all properties are now private, the constructor now takes an <code>IOTLPExportDelegate</code>, the type parameter for config type has been dropped. <ul> <li>This type is scheduled for removal in a future version of this package, please treat all exporters as <code>SpanExporter</code>, <code>PushMetricExporter</code> or <code>LogRecordExporter</code>, based on their respective type.</li> </ul> </li> </ul> </li> <li>feat(otlp-grpc-exporter-base)!: collapse base classes into one <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5031">#5031</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a> <ul> <li><code>OTLPGRPCExporterNodeBase</code> has been removed in favor of a platform-agnostic implementation (<code>OTLPExporterBase</code> from <code>@opentelemetry/otlp-exporter-base</code>)</li> </ul> </li> <li>feat(otlp-transformer)!: accept <code>ResourceMetrics</code> in serializers instead of <code>ResourceMetrics[]</code> <ul> <li>(user-facing): <code>ProtobufMetricsSerializer</code> now only accepts <code>ResourceMetrics</code> instead of <code>ResourceMetrics[]</code> to align with <code>PushMetricExporter</code> requirements</li> <li>(user-facing): <code>JsonMetricsSerializer</code> now only accepts <code>ResourceMetrics</code> instead of <code>ResourceMetrics[]</code> to align with <code>PushMetricExporter</code> requirements</li> </ul> </li> </ul> <h3>:rocket: (Enhancement)</h3> <ul> <li>feat(otlp-exporter-base): handle OTLP partial success <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5183">#5183</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a></li> <li>feat(otlp-exporter-base): internally accept a http header provider function only <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5179">#5179</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a></li> <li>refactor(otlp-exporter-base): don't create blob before sending xhr <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5193">#5193</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a> <ul> <li>improves compatibility with some unsupported runtimes</li> </ul> </li> <li>feat(otlp-exporter-base): add http response body to exporter error <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5204">#5204</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a></li> </ul> <h3>:bug: (Bug Fix)</h3> <ul> <li>fix(otlp-exporter-*): de-confuse Nuxt build tooling by not using 'export *' in comments <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5227">#5227</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a></li> </ul> <h3>:house: (Internal)</h3> <ul> <li>chore(otlp-exporter-*-grpc): clean up tests <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5196">#5196</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a></li> <li>chore(otlp-exporter-*-http): clean up tests <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5198">#5196</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a></li> <li>chore(otlp-exporter-*-proto): clean up tests <a href="https://redirect.github.com/open-telemetry/opentelemetry-js/pull/5199">#5196</a> <a href="https://github.com/pichlermarc"><code>@pichlermarc</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/85dcbc7c55f002837f1bf1bf01145dbb34a55b40"><code>85dcbc7</code></a> chore: prepare next release (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5232">#5232</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/b0f73ea11d22f65dc2b2bfe9ddcb0890ea74f533"><code>b0f73ea</code></a> fix: de-confuse Nuxt build tooling by not using 'export *' in comments (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5227">#5227</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/c9b5bb0bfeb77ab9ce238fc28b505daa87ed419e"><code>c9b5bb0</code></a> chore(deps): lock file maintenance (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5225">#5225</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/fc94e4669a94e688204a919165a020323fc1d5c2"><code>fc94e46</code></a> feat(otlp-exporter-base): implement partial success handling (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5183">#5183</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/fd7f2d951b4b760c6b957ca42f4a0f6b5fa600bd"><code>fd7f2d9</code></a> fix(deps): update dependency zone.js to v0.15.0 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5213">#5213</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/17bf0d9a344e7e4dd391d070c4d318f0783529e7"><code>17bf0d9</code></a> chore(deps): update dependency <code>@bufbuild/buf</code> to v1.47.2 (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5210">#5210</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/1249e34591d79407c488466ebd4340e84a6b0e9f"><code>1249e34</code></a> refactor(otlp-exporter-base): remove exports that were meant to be internal (...</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/5ad0aa544b680556be5c58ed05d2cea191c6e542"><code>5ad0aa5</code></a> chore: replace deprecated String.prototype.substr() with substring() (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5209">#5209</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/3bf12847d166db34967355a6de8cee5b4b70fab3"><code>3bf1284</code></a> feat(otlp-exporter-base): add http response body to exporter error (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5204">#5204</a>)</li> <li><a href="https://github.com/open-telemetry/opentelemetry-js/commit/561f8ad3a3b50c61f643d13a42bcd9c2006a6b57"><code>561f8ad</code></a> fix(docs): broken link for community contribution lifecycle and processes (<a href="https://redirect.github.com/open-telemetry/opentelemetry-js/issues/5">#5</a>...</li> <li>Additional commits viewable in <a href="https://github.com/open-telemetry/opentelemetry-js/compare/experimental/v0.55.0...experimental/v0.56.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Today, if you pass e.g. `Infinity` or another large number to `maxSpanWaitDuration`, the SDK will error out because we try to do `new Array(maxSpanWaitDuration)`, which is impossible. Ideally, we can properly allow an infinite wait time, but for now this adds checks to ensure only valid values are passed in there, and we do not explode. See #14154 (comment)
We do install this on CI separately before, so this should not be necessary (esp. we do not need firefox, as we only run these tests on chromium). This should shave off about 20s of the `build` step for all the E2E tests!
Lms24
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.