Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inp): Ensure INP spans have correct transaction #12871

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 11, 2024

Fixes #12855

Previously, we stored the route name of the pageload in a map for INP interactions. However, in some frameworks - e.g. remix, but also others, we update the pageload span name later (since we rely on e.g. react hooks for this etc).

Since we store the name of the pageload span at the time the first interaction is recorded, it can thus happen that these run out of sync.

This PR changes this so that instead of the routename itself, we store the pageload span in a map, and pick the last name of this when generating the INP span.

I added tests in a remix e2e tests that show the now correct behavior, these used to fail (because transaction on the pageload INP was /).

@mydea mydea self-assigned this Jul 11, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.31 KB (0%)
@sentry/browser (incl. Tracing) 33.65 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) 69.42 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.75 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.48 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 86.13 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.99 KB (+0.01% 🔺)
@sentry/browser (incl. metrics) 26.59 KB (0%)
@sentry/browser (incl. Feedback) 38.98 KB (0%)
@sentry/browser (incl. sendFeedback) 26.92 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.54 KB (0%)
@sentry/react 25.05 KB (0%)
@sentry/react (incl. Tracing) 36.69 KB (+0.01% 🔺)
@sentry/vue 26.41 KB (0%)
@sentry/vue (incl. Tracing) 35.53 KB (+0.01% 🔺)
@sentry/svelte 22.44 KB (0%)
CDN Bundle 23.52 KB (0%)
CDN Bundle (incl. Tracing) 35.42 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) 69.53 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.73 KB (-0.01% 🔽)
CDN Bundle - uncompressed 69.02 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 104.79 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 215.18 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.9 KB (+0.01% 🔺)
@sentry/nextjs (client) 36.57 KB (+0.02% 🔺)
@sentry/sveltekit (client) 34.3 KB (+0.01% 🔺)
@sentry/node 130.81 KB (-0.01% 🔽)
@sentry/node - without tracing 91.89 KB (0%)
@sentry/aws-serverless 117.06 KB (0%)

@@ -19,6 +19,7 @@ Sentry.init({
replaysSessionSampleRate: 0.1, // This sets the sample rate at 10%. You may want to change it to 100% while in development and then sample at a lower rate in production.
replaysOnErrorSampleRate: 1.0, // If you're not already sampling the entire session, change the sample rate to 100% when sampling sessions where errors occur.
tunnel: 'http://localhost:3031/', // proxy server
release: 'e2e-test',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potentially left over?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I added this to test that this is correctly set on the INP span :)

@mydea mydea merged commit ab4ac07 into develop Jul 11, 2024
116 checks passed
@mydea mydea deleted the fn/fix-inp-transaction branch July 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

INP transaction tag not matching pageload transaction
2 participants