fix: Apply stack frame metadata before event processors #12799
Merged
+232
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
timfish
approved these changes
Jul 9, 2024
mydea
reviewed
Jul 9, 2024
| return event; | ||
| client.on('applyFrameMetadata', event => { | ||
| // Only apply stack frame metadata to error events | ||
| if (event.type !== undefined) { |
There was a problem hiding this comment.
Suggested change
| if (event.type !== undefined) { | |
| if (event.type) { |
slightly smaller?
mydea
reviewed
Jul 9, 2024
|
|
||
| client.on('applyFrameMetadata', event => { | ||
| // Only apply stack frame metadata to error events | ||
| if (event.type !== undefined) { |
There was a problem hiding this comment.
Suggested change
| if (event.type !== undefined) { | |
| if (event.type) { |
mydea
approved these changes
Jul 9, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12704
Previously we had a bug where stack frame metadata wasn't properly applied when something rewrote the stack frame file names in a way that wouldn't allow us to associate the injected metadata stack traces with the stack frames. This boils down to a timing issue where we would attempt to write the stack frame metadata onto the stack frames after the event processors have run, even though we should do that before they run.
To solve this timing issue, this PR adds a hook
applyFrameMetadatato the client that signals the moment frame metadata should be attached. Additionally we update all of the integrations that make use of frame metadata to use this hook.