Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nestjs): Add nest cron monitoring support #12781

Merged
merged 16 commits into from
Jul 9, 2024
Merged

Conversation

nicohrubec
Copy link
Contributor

@nicohrubec nicohrubec commented Jul 5, 2024

Adds cron monitoring support to @sentry/nestjs.

Approach: @SentryCron decorator that applies Sentry.withMonitor on the decorated function. It is important that this decorator is applied below the native @Cron nest decorator (otherwise it doesn't work), but I will let the docs reflect that.

Testing:

  • Manually tested on my sample application.
  • Added an e2e test.

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi
@nicohrubec nicohrubec linked an issue Jul 5, 2024 that may be closed by this pull request
@nicohrubec nicohrubec self-assigned this Jul 5, 2024

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi
Copy link
Contributor

github-actions bot commented Jul 5, 2024

size-limit report 📦

Path Size
@sentry/browser 22.28 KB (0%)
@sentry/browser (incl. Tracing) 33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.87 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.73 KB (0%)
@sentry/browser (incl. metrics) 26.57 KB (0%)
@sentry/browser (incl. Feedback) 38.95 KB (0%)
@sentry/browser (incl. sendFeedback) 26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.52 KB (0%)
@sentry/react 25.02 KB (0%)
@sentry/react (incl. Tracing) 36.46 KB (0%)
@sentry/vue 26.39 KB (0%)
@sentry/vue (incl. Tracing) 35.29 KB (0%)
@sentry/svelte 22.41 KB (0%)
CDN Bundle 23.5 KB (0%)
CDN Bundle (incl. Tracing) 35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.48 KB (0%)
CDN Bundle - uncompressed 68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.09 KB (0%)
@sentry/nextjs (client) 36.35 KB (0%)
@sentry/sveltekit (client) 34.07 KB (0%)
@sentry/node 130.84 KB (+0.01% 🔺)
@sentry/node - without tracing 91.86 KB (0%)
@sentry/aws-serverless 117.03 KB (+0.01% 🔺)

nicohrubec and others added 11 commits July 5, 2024 13:18

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi
.

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi

Verified

This commit was signed with the committer’s verified signature.
oteffahi Oussama Teffahi
@nicohrubec nicohrubec marked this pull request as ready for review July 9, 2024 07:33
Co-authored-by: Luca Forstner <luca.forstner@sentry.io>
@nicohrubec nicohrubec requested a review from lforst July 9, 2024 09:32
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool! 🚀

@nicohrubec nicohrubec merged commit 580e6a4 into develop Jul 9, 2024
88 of 89 checks passed
@nicohrubec nicohrubec deleted the nh/nest-cron-support branch July 9, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add automatic cron monitoring support to @sentry/nestjs
3 participants