Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(scope): Delete unused public getStack() #12737

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 3, 2024

getStack() is a leftover from the Hub API and was removed with v8. The method does not need to be public anymore and therefore deleted.

@s1gr1d s1gr1d requested review from mydea and andreiborza July 3, 2024 08:34
Copy link
Contributor

github-actions bot commented Jul 3, 2024

size-limit report 📦

Path Size
@sentry/browser 22.28 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) 33.43 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) 69.18 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.51 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.24 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.85 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.71 KB (-0.01% 🔽)
@sentry/browser (incl. metrics) 26.57 KB (-0.03% 🔽)
@sentry/browser (incl. Feedback) 38.92 KB (-0.03% 🔽)
@sentry/browser (incl. sendFeedback) 26.9 KB (-0.02% 🔽)
@sentry/browser (incl. FeedbackAsync) 31.51 KB (-0.03% 🔽)
@sentry/react 25.02 KB (-0.03% 🔽)
@sentry/react (incl. Tracing) 36.48 KB (-0.02% 🔽)
@sentry/vue 26.39 KB (-0.04% 🔽)
@sentry/vue (incl. Tracing) 35.29 KB (-0.03% 🔽)
@sentry/svelte 22.41 KB (-0.04% 🔽)
CDN Bundle 23.49 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing) 35.18 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay) 69.28 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.47 KB (-0.01% 🔽)
CDN Bundle - uncompressed 68.94 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 103.96 KB (-0.05% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.35 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 227.06 KB (-0.03% 🔽)
@sentry/nextjs (client) 36.35 KB (-0.02% 🔽)
@sentry/sveltekit (client) 34.07 KB (-0.03% 🔽)
@sentry/node 130.75 KB (-0.01% 🔽)
@sentry/node - without tracing 91.77 KB (-0.01% 🔽)
@sentry/aws-serverless 116.94 KB (-0.01% 🔽)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ saved some bundle size 🚀

@mydea mydea force-pushed the sig/delete-getStack branch from d3264ae to 8aad058 Compare July 4, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants