-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Sentry ingestion does not block PR merges #11910
Labels
Comments
This was referenced May 28, 2024
mydea
added a commit
that referenced
this issue
May 28, 2024
This does two main things: 1. Updates node E2E tests to use `fetch` instead of axios 2. Update node E2E tests to avoid sending to Sentry. Instead, we check everywhere via the proxy that the data sent is OK. Part of #11910
mydea
added a commit
that referenced
this issue
May 29, 2024
This adds a new E2E test `react-send-to-sentry` that is run optionally. For now this is the same as the old `standard-frontend-react` test - eventually we can/should update that test (and others) to stop sending to sentry. This test will run in a separate group that we do not block merging on when it fails. For now, there is one browser and one node test that checks that they send events successfully to Sentry - IMHO that should cover stuff decently for now. I also made the source maps debug ID test optional, as that inherently sends to Sentry. We can in follow ups get rid of all the event sending stuff from the remaining E2E tests. Part of #11910
This was referenced May 31, 2024
mydea
added a commit
that referenced
this issue
May 31, 2024
mydea
added a commit
that referenced
this issue
May 31, 2024
Part of #11910 - we already have error & transaction tests there, so we can just delete the sending tests.
c298lee
pushed a commit
that referenced
this issue
Jun 4, 2024
c298lee
pushed a commit
that referenced
this issue
Jun 4, 2024
Part of #11910 - we already have error & transaction tests there, so we can just delete the sending tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today, most of our E2E tests ensure we send payloads to Sentry. This means we wait for stuff to be ingested by Sentry, which also means that if that is delayed or broken the tests failed, meaning we cannot merge PRs.
We do not want to be blocked like this. So to fix this, I propose that we:
The text was updated successfully, but these errors were encountered: