Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add "maxCanvasSize" option for replay canvases #11732

Merged
merged 2 commits into from Apr 23, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Apr 22, 2024

We do not want to allow users to capture super large canvases, enforce a
max size limit

Requires getsentry/rrweb#174
Closes #10498
Backport of #11617

We do not want to allow users to capture super large canvases, enforce a
max size limit

Requires getsentry/rrweb#174
Closes #10498
Backport of #11617
@billyvg billyvg changed the base branch from develop to v7 April 22, 2024 19:43
@billyvg billyvg changed the title build(profiling-node): make sure debug build plugin is used (#10534) feat(replay): Add "maxCanvasSize" option for replay canvases Apr 22, 2024
@billyvg billyvg mentioned this pull request Apr 22, 2024
@billyvg billyvg marked this pull request as ready for review April 22, 2024 19:47
@billyvg billyvg requested a review from a team April 22, 2024 19:55
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.72 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.69 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.91 KB (+0.46% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.32 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.62 KB (+0.37% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.5 KB (+0.38% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.57 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.58 KB (0%)
@sentry/browser - Webpack (gzipped) 22.78 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.9 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.27 KB (+0.22% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 36.02 KB (+0.36% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.27 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 221.25 KB (+0.24% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 109.01 KB (+0.45% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.79 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.3 KB (+0.35% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.18 KB (+0.21% 🔺)
@sentry/react - Webpack (gzipped) 22.81 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 90.01 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 54.15 KB (+0.26% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.32 KB (0%)

@mydea mydea merged commit 6a0a4c6 into v7 Apr 23, 2024
104 checks passed
@mydea mydea deleted the feat-replay-add-max-size-canvas branch April 23, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sentry/profiling-node: ReferenceError: __DEBUG_BUILD__ is not defined
4 participants