feat(v7): Export pluggable integrations from SDK packages #11723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Apr 22, 2024
| @@ -3,7 +3,7 @@ | |||
| /* eslint-disable deprecation/deprecation */ | |||
| import type { Event, EventProcessor, Hub, Integration } from '@sentry/types'; | |||
| import { GLOBAL_OBJ, logger, normalize, uuid4 } from '@sentry/utils'; | |||
| import localForage from 'localforage'; | |||
| import * as localForage from 'localforage'; | |||
There was a problem hiding this comment.
Without this deno complained at build time, even if this is not used by the package 😬
Closed
mydea
commented
Apr 23, 2024
| @@ -35,7 +35,6 @@ | |||
| "localforage": "^1.8.1" | |||
| }, | |||
| "devDependencies": { | |||
| "@sentry/browser": "7.111.0", | |||
There was a problem hiding this comment.
This lead to a circular dependency, and we only used it in a single test for WINDOW anyhow 😬
size-limit report 📦
|
Lms24
approved these changes
Apr 23, 2024
mydea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exports the functional integrations from
@sentry/integrationsfrom each package.In v8, the
@sentry/integrationspackage will be gone, and the migration path is to just use it from the SDK package itself.