Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nextjs/v7): Fix tunnelRoute matching logic for hybrid cloud #11577

Merged
merged 2 commits into from Apr 12, 2024
Merged

fix(nextjs/v7): Fix tunnelRoute matching logic for hybrid cloud #11577

merged 2 commits into from Apr 12, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Apr 12, 2024

Fixes #11559

Multiple issues:

  • order of matchers
  • escaped regex

@lforst lforst marked this pull request as ready for review April 12, 2024 10:54
@lforst lforst mentioned this pull request Apr 12, 2024
Closed
jjbayer
jjbayer approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needed?

@lforst
Copy link
Member Author

lforst commented Apr 12, 2024

definitely but gonna do them in a followup cause its a bit of work

@lforst lforst merged commit fadc9ac into v7 Apr 12, 2024
60 checks passed
@lforst lforst deleted the lforst-fix-tunnelroute-hc-v7 branch April 12, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lforst @jjbayer