feat(v7/core): Deprecate Hub class
#11528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
approved these changes
Apr 10, 2024
Lms24
force-pushed
the
lms/feat-core-v7-deprecate-hub-class
branch
from
98f41ee
to
b28e35e
Compare
size-limit report 📦
|
AbhiPrasad
pushed a commit
that referenced
this pull request
Apr 10, 2024
This PR deprecates the `Hub` interface as a continuation of #11528 where we deprecated the Hub class. The difference here is that the interface will stay deprecated throughout v8 so that we can shim the infamous `getCurrentHub` API. Most other usages of the interface should already be removed in v8/`develop` 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecated the
Hubclass which I'll remove in a follow-up PR in v8. The replacement is to mostly use the scope-centered APIs. Most APIs that relied on theHubclass (unfortunately quite a lot - looks like we weren't really consistent in using the Hub interface instead of the class) are already deprecated and already removed in v8.The one exception where we have to break a little is
getCurrentHubwhich we decided to still keep around as deprecated throughout the lifetime of v8. SincegetCurrentHubreturns the class instead of the interface, I suggest we simply switch it to the interface. If the class exports more members than the interface declares, we'll probably need to add them to the interface.ref #11482