Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Update metric normalization (v7) #11519

Merged
merged 1 commit into from Apr 10, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 9, 2024

Backport of #11518 for v7

@timfish timfish marked this pull request as ready for review April 9, 2024 21:27
Copy link
Contributor

github-actions bot commented Apr 9, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.54 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.52 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.54 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.16 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.46 KB (+0.15% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.34 KB (+0.14% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.53 KB (+0.03% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.54 KB (+0.03% 🔺)
@sentry/browser - Webpack (gzipped) 22.74 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.73 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.1 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.88 KB (+0.31% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.25 KB (+0.35% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.66 KB (+0.16% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.46 KB (+0.32% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.73 KB (+0.32% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.14 KB (+0.37% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.01 KB (+0.07% 🔺)
@sentry/react - Webpack (gzipped) 22.78 KB (+0.04% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.85 KB (+0.05% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.99 KB (+0.08% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

This was referenced Apr 10, 2024
@AbhiPrasad
Copy link
Member

looks like size limit is failing?

@timfish
Copy link
Collaborator Author

timfish commented Apr 10, 2024

The percentage increased makes sense but when I looked at the JSON output of the size check it doesn't make sense.

@AbhiPrasad AbhiPrasad merged commit 1c0194a into v7 Apr 10, 2024
102 of 103 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/metrics-normalisation-backport branch April 10, 2024 17:29
@AbhiPrasad
Copy link
Member

Let's just merge, we can fix it later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants