Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): [v7] unref timer to not block node exit #11483

Merged
merged 1 commit into from Apr 8, 2024
Merged

fix(core): [v7] unref timer to not block node exit #11483

merged 1 commit into from Apr 8, 2024

Conversation

AbhiPrasad
Copy link
Member

This backports #11430 to v7

@AbhiPrasad
fix(core): unref timer to not block node exit (#11430)
5ab3631 
Add `unref` to make sure that the session flusher or metrics aggregator
does not block nodejs exit. Especially important for serverless
scenarios.
@AbhiPrasad AbhiPrasad requested review from timfish, a team, mydea and Lms24 and removed request for a team April 8, 2024 14:31
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 8, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.53 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.52 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.54 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.15 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.45 KB (+0.13% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.33 KB (+0.12% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.52 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.53 KB (0%)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.64 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.01 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.8 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.41 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.22 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.02 KB (+0.08% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.01 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped) 22.77 KB (+0.01% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.85 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.99 KB (+0.07% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@AbhiPrasad AbhiPrasad merged commit 43b83a6 into v7 Apr 8, 2024
103 checks passed
@AbhiPrasad AbhiPrasad deleted the v7-node-unref branch April 8, 2024 15:29
@AbhiPrasad AbhiPrasad mentioned this pull request Apr 10, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@mydea mydea mydea approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AbhiPrasad @timfish @mydea