Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spans): Allow zero exclusive time for INP spans #11408

Merged
merged 2 commits into from Apr 3, 2024

Conversation

edwardgou-sentry
Copy link

Allows exclusive time for spans to be 0, including inp spans.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for this!

Copy link
Contributor

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.53 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.52 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.54 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.15 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.45 KB (+0.13% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.33 KB (+0.12% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.52 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.53 KB (0%)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.64 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.01 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.8 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.41 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.22 KB (+0.1% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39.02 KB (+0.08% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 72.01 KB (+0.06% 🔺)
@sentry/react - Webpack (gzipped) 22.77 KB (+0.01% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.85 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.98 KB (+0.06% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@AbhiPrasad AbhiPrasad mentioned this pull request Apr 3, 2024
@edwardgou-sentry edwardgou-sentry merged commit 9bfadb5 into v7 Apr 3, 2024
103 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/fix/allow-zero-exclusive-time-for-spans branch April 3, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants