Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webvitals): Fix interactionIdToRouteNameMapping not being maintained properly and sometimes not sending INP spans #11183

Merged
merged 3 commits into from Mar 19, 2024

Conversation

edwardgou-sentry
Copy link

@edwardgou-sentry edwardgou-sentry commented Mar 18, 2024

Fixes scenarios where interaction tracking wasn't properly recording up to 10 candidate INP interactions.
Fixes first-input interaction not always tracked as INP candidates.
Fixes INP candidates not always using the longest latency even in their interaction id grouping.

Also fixes: #11156

Copy link
Contributor

github-actions bot commented Mar 18, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.18 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.28 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.26 KB (+0.08% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 64.91 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.22 KB (+0.16% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.11 KB (+0.19% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.44 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.45 KB (0%)
@sentry/browser - Webpack (gzipped) 22.68 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.38 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.78 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.58 KB (+0.17% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.11 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 219.75 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 107.56 KB (+0.19% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.38 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 38.8 KB (+0.06% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 71.77 KB (+0.11% 🔺)
@sentry/react - Webpack (gzipped) 22.71 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.61 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.77 KB (+0.2% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.28 KB (0%)

@edwardgou-sentry edwardgou-sentry force-pushed the egou/fix/inp-interaction-to-route-name-mapping-bugs branch from c8d1c12 to 8b1871e Compare March 18, 2024 21:24
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 18, 2024
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review March 19, 2024 03:38
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

@AbhiPrasad AbhiPrasad merged commit 0e9cddf into v7 Mar 19, 2024
104 checks passed
@AbhiPrasad AbhiPrasad deleted the egou/fix/inp-interaction-to-route-name-mapping-bugs branch March 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants