Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Deprecate getActiveTransaction() & scope.getTransaction() #10098

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 8, 2024

A lot to refactor for us... but for now, let's deprecate this.

@mydea mydea self-assigned this Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 8, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 76.49 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 67.88 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.5 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.13 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.7 KB (0%)
@sentry/browser - Webpack (gzipped) 22.07 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 74.1 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 65.75 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 31.93 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 23.76 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 206.52 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 96.4 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 70.93 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 34.89 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.25 KB (0%)
@sentry/react - Webpack (gzipped) 22.09 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 84.97 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.33 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 16.74 KB (0%)

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

christ this is gonna be the most painful one to clean up.

@mydea mydea force-pushed the fn/deprecateGetActiveTransaction branch from 8a68bc3 to a14325e Compare January 8, 2024 14:58
@mydea mydea force-pushed the fn/deprecateGetActiveTransaction branch from a14325e to a1f3cbf Compare January 8, 2024 15:28
@mydea mydea merged commit d305c8d into develop Jan 8, 2024
95 checks passed
@mydea mydea deleted the fn/deprecateGetActiveTransaction branch January 8, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants