-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Deprecate startTransaction()
#10073
Conversation
f795461
to
6cb3c2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
return parentSpan | ||
? parentSpan.startChild(ctx) | ||
: // eslint-disable-next-line deprecation/deprecation | ||
hub.startTransaction(ctx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not relevant for this PR but this makes me realize we'll probably need to create an internal startTxn
utility for us as a replacement of hub.startTransaction
when its removed as long as we're still sending spans in transacitons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jup, also had that thought - for now we'll still need some internal thing, but we can refactor this on the v8 branch then I'd say :)
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This finally deprecates `startTransaction()`. There are only few remaining usages in our own code base, which we can refactor as we go. I chose to leave usages in E2E/integration tests for now, we can then refactor them when we get rid of these to ensure the behavior remains the same. --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This finally deprecates
startTransaction()
. There are only few remaining usages in our own code base, which we can refactor as we go.I chose to leave usages in E2E/integration tests for now, we can then refactor them when we get rid of these to ensure the behavior remains the same.