feat(core): Deprecate Hub.shouldSendDefaultPii
#10062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/feat-deprecate-shouldSendDefaultPii
branch
3 times, most recently
from
296ae43
to
c486356
Compare
mydea
approved these changes
Jan 4, 2024
Lms24
force-pushed
the
lms/feat-deprecate-shouldSendDefaultPii
branch
from
c486356
to
020deb2
Compare
Lms24
force-pushed
the
lms/feat-deprecate-shouldSendDefaultPii
branch
from
020deb2
to
937eba5
Compare
Lms24
force-pushed
the
lms/feat-deprecate-shouldSendDefaultPii
branch
from
937eba5
to
ae5444b
Compare
c298lee
pushed a commit
that referenced
this pull request
Jan 9, 2024
Deprecates the unnecessary `Hub. shouldSendDefaultPii` method which can be easily replaced by accessing client options directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick one for a change...
This PR only deprecates the unnecessary
Hub. shouldSendDefaultPiimethod which can be easily replaced by accessing client options directly. Replacement of usages was already done in #9899, hence, only the deprecation is left.