feat(core): Deprecate span name
and description
#10056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, users should use
spanToJSON(span).description
.In reality, users should mostly not actually need this - most usages are internal things, or tests, right now.
While at this, I also updated the
TraceContext
type to not have adescription
. This started failing in a bunch of tests, because while in theory the trace context has adescription
field, in praxis we always used to setdescription
toundefined
for transactions, leading to this never being set. The work in this PR unifies the name/description handling between span and transaction, which lead todescription
not being undefined for transactions anymore, leading to this actually showing up in the trace context.