Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #3124

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix typo #3124

merged 1 commit into from
Jan 2, 2024

Conversation

oioki
Copy link
Member

@oioki oioki commented Jan 2, 2024

#skip-changelog

Copy link
Contributor

github-actions bot commented Jan 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.33 ms 515.94 ms 85.61 ms
Size 1.72 MiB 2.27 MiB 558.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4bf95dd 345.96 ms 414.24 ms 68.28 ms
d6d2b2e 413.20 ms 486.76 ms 73.56 ms
d6d2b2e 463.14 ms 545.56 ms 82.42 ms
0404ea3 332.47 ms 401.12 ms 68.66 ms
2fad834 390.07 ms 470.80 ms 80.73 ms
d429384 397.33 ms 457.69 ms 60.36 ms
937879e 417.64 ms 550.45 ms 132.81 ms
d6d2b2e 392.55 ms 467.50 ms 74.95 ms
c3f503e 360.41 ms 434.67 ms 74.27 ms
4e29063 384.14 ms 447.74 ms 63.60 ms

App size

Revision Plain With Sentry Diff
4bf95dd 1.72 MiB 2.29 MiB 576.40 KiB
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
0404ea3 1.72 MiB 2.29 MiB 577.52 KiB
2fad834 1.72 MiB 2.29 MiB 577.53 KiB
d429384 1.72 MiB 2.27 MiB 558.42 KiB
937879e 1.72 MiB 2.27 MiB 558.42 KiB
d6d2b2e 1.72 MiB 2.27 MiB 555.05 KiB
c3f503e 1.72 MiB 2.29 MiB 577.04 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@romtsn romtsn merged commit baaf637 into main Jan 2, 2024
@romtsn romtsn deleted the fix/typo-objecr branch January 2, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants