Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Exception.ThreadID type #770

Merged
merged 1 commit into from Feb 7, 2024
Merged

Fix Exception.ThreadID type #770

merged 1 commit into from Feb 7, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Feb 7, 2024

Closes #767

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (824589b) 80.88% compared to head (3658763) 81.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   80.88%   81.03%   +0.14%     
==========================================
  Files          48       48              
  Lines        4714     4714              
==========================================
+ Hits         3813     3820       +7     
+ Misses        763      758       -5     
+ Partials      138      136       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric changed the title Fix Exception.ThreadID type Fix Exception.ThreadID type Feb 7, 2024
@cleptric cleptric merged commit 4185c9f into master Feb 7, 2024
17 checks passed
@cleptric cleptric deleted the fix-thread-id-type branch February 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thread_id is typed as a string but Sentry actually sends ints
2 participants