Attempt to scrub all Plug.Conns in Sentry.PlugCapture
#619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
reviewed
Oct 4, 2023
| # We can't pattern match here, because we're not guaranteed to have | ||
| # Phoenix available. | ||
| exception = | ||
| if is_struct(exception, Phoenix.ActionClauseError) do |
There was a problem hiding this comment.
isn't doing this just for ActionClauseError too limited?
like it solves the issue but similar leakage could happen in other exceptions too right?
sl0thentr0py
approved these changes
Oct 4, 2023
|
@sl0thentr0py sadly we can't really do that, because we're being very specific with the shape of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #477.
This is not foolproof, but I think it's pretty effective.