Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft-deprecate Sentry.EventFilter #608

Merged
merged 1 commit into from Sep 12, 2023
Merged

Conversation

whatyouhide
Copy link
Collaborator

@whatyouhide whatyouhide commented Sep 8, 2023

We don't really have this in other SDKs. The event pipeline described in the Unified API only mentions

Sentry invokes the before-send hook.

There's no mention of an event filter. Since the "before-send hook" is a superset of the event filter, maybe we can get rid of the event filter and contextually fix #512 and #536?

Fixes #512.
Fixes #536.

@whatyouhide whatyouhide merged commit d95a77c into master Sep 12, 2023
1 of 3 checks passed
@whatyouhide whatyouhide deleted the al/deprecate-event-filter branch September 12, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant